Added condition when downloading record for notification with stream_status finished #102
Conversation
vitorsemeano
changed the title
vitorsemeano
changed the title
added missing imports in downloader.py
pytapo/media_stream/downloader.py
Outdated
| import logging | ||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
Logger is passed from Home Assistant to init.py as printDebugInformation parameter.
I believe we should use the same approach here, use tapo object passed to Downloader class and use its function debugLog.
There was a problem hiding this comment.
We can delete this and use self.tapo.debugLog() call.
There was a problem hiding this comment.
deleted and replaced logger.warning with debugLog
pytapo/media_stream/session.py
Outdated
| # print(plaintext) | ||
|
|
||
| # # Update our own sequence numbers to avoid collisions | ||
| # if (seq is not None) and (seq > self._seq_counter): | ||
| # self._seq_counter = seq + 1 | ||
|
|
There was a problem hiding this comment.
I removed this block of comments and also the print comments in this file for clarity.
pytapo/media_stream/downloader.py
Outdated
| downloading = False | ||
| break | ||
| except JSONDecodeError: | ||
| logger.warning("Unable to parse JSON sent from device") |
There was a problem hiding this comment.
Use self.tapo.debugLog() call.
Sure, i will do the changes now and push shortly. |
|
@JurajNyiri all done, if you need something else, just ask. |
|
Thank you! |
… with stream_status finished
Closes JurajNyiri/HomeAssistant-Tapo-Control#523
During the download of a record, the camera is sending a json response, notifying that the download finished.
Since the code is not ready for this notification, it never assumed a complete record, entering in a loop between retrying and downloading the same record.
This code prevents the situation, expecting to find the json response, and if such situation occurs, assumes that the download is finished.
For reference, the response to find is the following:
b'{"type":"notification", "params":{"event_type":"stream_status", "status":"finished"}}'Also added missing dependency rtp for tox.